apalrd wrote:
I would probably add some additional calculation to guarantee that the over-rev target speed is at least ~500 RPM above the idle speed target. This prevents them from interacting in bad ways, e.g. if you start to slip at 2MPH and it calculates a 900RPM rev limit for traction control.
Maybe.
The way its coded the idle stae conditions are checked before TC or Rev so is those conditions are met it really wouldn't matter what TC or Rev wanted to do...but stopping the user from entering BS numbers is never a bad idea.
I've been pondering in a bit more.....idle works cleanly becasue when it has control of the throttle it has control of the throttle and I think the only way to make the rev controller/state stable is to give the rev controller control and let it do as it pleases for at least short amount of time so it can overshoot the user position. I might play with that a bit.